[ 
https://issues.apache.org/jira/browse/SEDONA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347208#comment-17347208
 ] 

Jia Yu commented on SEDONA-34:
------------------------------

This PR seems to require lots of work for revamping the test cases. It requires 
much more thinking than I expected before.

 

Step 1: remove redundant test cases in core/sql/viz/python/python-adapter.

Step 2: make test cases re-use certain input files

Step 3: delete the unused test files

> Stop using real world data in unit tests
> ----------------------------------------
>
>                 Key: SEDONA-34
>                 URL: https://issues.apache.org/jira/browse/SEDONA-34
>             Project: Apache Sedona
>          Issue Type: Task
>            Reporter: Jia Yu
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, Sedona unit tests heavily rely on external data stored in 
> core/test/resources folders. This results in two problems
>  # The source code size is big. Any user who wants to download the source 
> code has to download all these test data.
>  # The copyright of these data is unclear. Some data is publicly available on 
> their website but without giving any proper license. E.g., USGS TIGER data.
>  # Some test cases rely on hand-tuned test data. This is not good for 
> debugging and long-term maintenance.
>  
> Solution: Try to assemble synthetic datasets by Sedona itself and use them in 
> /share across Sedona test cases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to