jiayuasu commented on a change in pull request #521:
URL: https://github.com/apache/incubator-sedona/pull/521#discussion_r635837137
##########
File path: .github/workflows/r.yml
##########
@@ -0,0 +1,129 @@
+name: R build
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - '*'
+
+jobs:
+ build:
+
+ runs-on: ubuntu-18.04
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - name: 'Spark 3.0.1 (R release)'
+ r: 'release'
+ env:
+ SPARK_VERSION: '3.0.1'
Review comment:
Could you please upgrade the CI to support Spark 3.1.1?
Please see our latest CI example
https://github.com/apache/incubator-sedona/blob/master/.github/workflows/java.yml#L43
##########
File path: R/sparklyr.sedona/DESCRIPTION
##########
@@ -0,0 +1,29 @@
+Type: Package
+Package: sparklyr.sedona
+Title: Sparklyr Extension for Apache Sedona
+Version: 0.1.0
+Authors@R:
Review comment:
Could you change the maintainer name to Apache Sedona? See here:
https://github.com/apache/incubator-sedona/blob/master/python/setup.py#L33
##########
File path: R/sparklyr.sedona/inst/extdata/arealm-tiny.csv
##########
@@ -0,0 +1,5 @@
+testattribute0,-88.331492,32.324142,testattribute1,testattribute2
Review comment:
Can you re-use the test data provided in
https://github.com/apache/incubator-sedona/tree/master/core/src/test/resources,
by referring to their relative path? Currently Sedona has too many test data
files. It leads to some maintenance-wise and copyright-wise issues. We plan to
reuse and remove some of them in the future. See
[SEDONA-34](https://issues.apache.org/jira/browse/SEDONA-34)
##########
File path: R/sparklyr.sedona/man/sedona_read_geojson_to_typed_rdd.Rd
##########
@@ -0,0 +1,64 @@
+% Generated by roxygen2: do not edit by hand
Review comment:
For the documentation, please do not include generated docs in the PR.
Please include the source code of docs in the PR. Generated R docs will be
manually integrated with generated html files (based on incubator-sedona/docs/)
and uploaded to https://github.com/apache/incubator-sedona-website/tree/asf-site
I believe the R docs itself could be a separate PR since it requires some
structure change or doc change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
