Kimahriman opened a new pull request #557:
URL: https://github.com/apache/incubator-sedona/pull/557


   ## Is this PR related to a proposed Issue?
   https://issues.apache.org/jira/browse/SEDONA-67
   
   ## What changes were proposed in this PR?
   Adds support for Spark 3.2, but maintains compatibilities.
   
   Specifically to get 3.2 working I had to:
   - Rework how functions are registered to use an API present in all supported 
versions of Spark.
   - Add `withNewChildrenInternal` to all expressions. Without using 
`override`, it works both in the new version to override it as well as in older 
versions it's just ignored.
   - Add a new profile for Spark 3.2 because it needs a newer version of 
jackson to test with
   
   Additionally I cleaned up a few things:
   - Removed assert statements from the eval method of expressions. This is an 
analysis time check that can be done on instantiation of the case class
   - Removed a bunch of return statements to make things consistent
   
   ## How was this patch tested?
   Existing tests, though I do need help figuring out how the github workflow 
should be updated.
   
   ## Did this PR include necessary documentation updates?
   Haven't looked at the documentation yet, probably need to update a 
compatibility page still


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to