Kimahriman commented on a change in pull request #562:
URL: https://github.com/apache/incubator-sedona/pull/562#discussion_r748345778
##########
File path: .github/workflows/java.yml
##########
@@ -23,6 +23,9 @@ jobs:
scala: 2.11.8
- spark: 3.0.3
scala: 2.11.8
+ include:
Review comment:
Doesn't
```
run: if [ ${SPARK_VERSION:0:1} == "3" ]; then mvn -q clean install
-Dscala=${SCALA_VERSION:0:4} -Dspark=3.0 ; else mvn -q clean install
-Dscala=${SCALA_VERSION:0:4} -Dspark=2.4 ; fi
```
already handle that? It looks like that test did run with scala 2.13 in the
actions (I see deprecation warnings). Also, since the patch version is ignored
in the tests should the scala version just be set to the minor version in the
matrix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
