ericsun95 commented on code in PR #607:
URL: https://github.com/apache/incubator-sedona/pull/607#discussion_r896775498


##########
sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/geoparquet/ParquetFileFormat.scala:
##########
@@ -0,0 +1,545 @@
+/*

Review Comment:
   Looks like all these are duplicated with Spark internal parquet reader 
implementation. From my understanding the geoparquet is just one specific type 
of parquet with its only schema. 
   Generally, what differs here? how about implementing a very lean layer on 
top of spark native parquet file reader using DataSourceV2 interface with 
specific schema? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to