Imbruced commented on code in PR #693: URL: https://github.com/apache/incubator-sedona/pull/693#discussion_r979268764
########## python/tests/sql/test_dataframe_api.py: ########## @@ -0,0 +1,1087 @@ +import math + +from pyspark.sql import functions as f + +from sedona.sql import st_functions as stf +from sedona.sql import st_constructors as stc +from sedona.sql import st_aggregates as sta +from sedona.sql import st_predicates as stp +from tests.test_base import TestBase + +class TestDataFrameAPI(TestBase): + + def test_call_function_using_columns(self): Review Comment: Do you think parametrised tests can help to simplify the tests ? I mean https://docs.pytest.org/en/6.2.x/parametrize.html ? ########## python/tests/sql/test_dataframe_api.py: ########## @@ -0,0 +1,1087 @@ +import math + +from pyspark.sql import functions as f + +from sedona.sql import st_functions as stf +from sedona.sql import st_constructors as stc +from sedona.sql import st_aggregates as sta +from sedona.sql import st_predicates as stp +from tests.test_base import TestBase + +class TestDataFrameAPI(TestBase): + + def test_call_function_using_columns(self): Review Comment: Then you can use argument list, function name to apply and also some fixtures to provide dataframe ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
