tanelk commented on code in PR #711: URL: https://github.com/apache/incubator-sedona/pull/711#discussion_r1026563488
########## sql/src/test/scala/org/apache/sedona/sql/BroadcastIndexJoinSuite.scala: ########## @@ -19,37 +19,42 @@ package org.apache.sedona.sql +import org.apache.spark.sql.execution.joins.BroadcastNestedLoopJoinExec import org.apache.spark.sql.sedona_sql.strategy.join.BroadcastIndexJoinExec import org.apache.spark.sql.functions._ class BroadcastIndexJoinSuite extends TestBaseScala { - describe("Sedona-SQL Broadcast Index Join Test") { + describe("Sedona-SQL Broadcast Index Join Test for inner joins") { // Using UDFs rather than lit prevents optimizations that would circumvent the checks we want to test - val one = udf(() => 1) - val two = udf(() => 2) + val one = udf(() => 1).asNondeterministic() Review Comment: Added nondeterminist so the optimizer could modify the plans even less -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org