jiayuasu commented on code in PR #737:
URL: https://github.com/apache/incubator-sedona/pull/737#discussion_r1051529391
##########
python/tests/sql/test_function.py:
##########
@@ -50,6 +50,22 @@ class TestPredicateJoin(TestBase):
]
)
+ def test_st_concave_hull(self):
+ polygon_wkt_df = self.spark.read.format("csv"). \
+ option("delimiter", "\t"). \
+ option("header", "false"). \
+ load(mixed_wkt_geometry_input_location)
+
+ polygon_wkt_df.createOrReplaceTempView("polygontable")
+ polygon_wkt_df.show()
+
+ polygon_df = self.spark.sql("select ST_GeomFromWKT(polygontable._c0)
as countyshape from polygontable")
+ polygon_df.createOrReplaceTempView("polygondf")
+ polygon_df.show()
+
+ function_df = self.spark.sql("select
ST_ConcaveHull(polygondf.countyshape, 1.0) from polygondf")
+ function_df.show()
Review Comment:
Please do not use `show` to verify the result. Use assertion to decide if a
result is expected
##########
docs/api/sql/Function.md:
##########
@@ -332,6 +332,22 @@ Result:
+----------------------------------------------------------------------------+
```
+## ST_ConcaveHull
+
+Introduction: Return the Concave Hull of polgyon A, with alpha set to
pctConvex[0, 1] in the Delaunay Triangulation method, the concave hull will not
contain a hole unless allowHoles is set to true
+
+Format: `ST_ConcaveHull (A:geometry, pctConvex:float)`
+
+Format: `ST_ConcaveHull (A:geometry, pctConvex:float, allowHoles:Boolean)`
+
+Since: `v1.3.1`
Review Comment:
Sorry. Please change this to 1.3.2. I forgot to update the versions in POM
file.
##########
docs/archive/api/sql/GeoSparkSQL-Function.md:
##########
@@ -12,6 +12,20 @@ SELECT ST_Distance(polygondf.countyshape,
polygondf.countyshape)
FROM polygondf
```
+## ST_ConcaveHull
Review Comment:
Please do not update the archived GeoSpark func
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
