jiayuasu commented on PR #743: URL: https://github.com/apache/incubator-sedona/pull/743#issuecomment-1369390537
@Kimahriman I don't think it is a good idea to include logging dependencies in Sedona. Since Spark and Flink already package their own versions of log4j or slf4j, including these dependencies by ourselves are likely to create conflicts in the future. This will introduce additional complexity to the project management and cause potential bugs. For the common module, I think we should just use the regular java exception mechanism and let `sedona-spark` and `sedona-flink` to handle exceptions using log4j/slf4j packaged in Spark and Flink. Please correct me if I am wrong :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
