the-sea commented on code in PR #801:
URL: https://github.com/apache/sedona/pull/801#discussion_r1140904400
##########
zeppelin/index.js:
##########
@@ -109,21 +114,33 @@ export default class LeafletMap extends Visualization {
map.invalidateSize(true)
var imageBounds = null
- const markers = chartDataModel.rows.map(
+ const markers = chartDataModel.rows.flatMap(
row => {
const {image, boundary, info} = row;
+ var markers = [];
+
// throw new Error(image);
var jsts = require("jsts");
// Read WKT string from Sedona
var reader = new jsts.io.WKTReader();
- var obj = reader.read(boundary)
+ var obj = reader.read(boundary);
// Collect the centroid point of the
input geometry
var centroid = obj.getCentroid()
Review Comment:
Thank you for reviewing. Here is the point I want to discuss.If we don't
plot centroid point, it will be hard for us to find the shape, so I keep it.
If we want to do better, we can choose whether to display the center point
marker based on the zoom level, but implementing this will be more complicated.
Which solution do you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
