zongsizhang commented on code in PR #823:
URL: https://github.com/apache/sedona/pull/823#discussion_r1174756150
##########
sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_functions.scala:
##########
@@ -75,8 +74,8 @@ object st_functions extends DataFrameAPI {
def ST_Collect(geoms: String): Column = wrapExpression[ST_Collect](geoms)
def ST_Collect(geoms: Any*): Column = wrapVarArgExpression[ST_Collect](geoms)
- def ST_CollectionExtract(collection: Column): Column =
wrapExpression[ST_CollectionExtract](collection)
- def ST_CollectionExtract(collection: String): Column =
wrapExpression[ST_CollectionExtract](collection)
+ def ST_CollectionExtract(collection: Column): Column =
wrapExpression[ST_CollectionExtract](collection, null)
Review Comment:
it won't affect API, we just change the way to handle such overloading like
expressions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
