jiayuasu commented on code in PR #867:
URL: https://github.com/apache/sedona/pull/867#discussion_r1238160222
##########
docs/api/sql/Function.md:
##########
@@ -400,6 +400,20 @@ Result:
POLYGON ((0 -3, -3 -3, -3 3, 0 3, 0 -3))
```
+## ST_Dimension
+
+Introduction: Return the topological dimension of this Geometry object, which
must be less than or equal to the coordinate dimension. OGC SPEC s2.1.1.1 -
returns 0 for POINT, 1 for LINESTRING, 2 for POLYGON, and the largest dimension
of the components of a GEOMETRYCOLLECTION. If the dimension is unknown (e.g.
for an empty GEOMETRYCOLLECTION) 0 is returned.
+
+Format: `ST_Dimension (A:geometry), ST_Dimension (C:geometrycolletion), `
+
+Since: `v1.0.0`
+
+Spark SQL example:
+```sql
+SELECT ST_Dimension('GEOMETRYCOLLECTION(LINESTRING(1 1,0 0),POINT(0 0))');
Review Comment:
Please provide the output of the example.
In addition, have you tested other possible types, such as MultiPoint,
MultiLineString, MultiPolygon. GeometryCollection can also have nested `Multi`
objects.
We are trying to provide consistent behavior as PostGIS. Please install
PostGIS on your end and test the output in PostGIS as well.
##########
docs/api/sql/Function.md:
##########
@@ -400,6 +400,20 @@ Result:
POLYGON ((0 -3, -3 -3, -3 3, 0 3, 0 -3))
```
+## ST_Dimension
+
+Introduction: Return the topological dimension of this Geometry object, which
must be less than or equal to the coordinate dimension. OGC SPEC s2.1.1.1 -
returns 0 for POINT, 1 for LINESTRING, 2 for POLYGON, and the largest dimension
of the components of a GEOMETRYCOLLECTION. If the dimension is unknown (e.g.
for an empty GEOMETRYCOLLECTION) 0 is returned.
+
+Format: `ST_Dimension (A:geometry), ST_Dimension (C:geometrycolletion), `
+
+Since: `v1.0.0`
Review Comment:
Should be `v1.5.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
