Thanks, Adam. I agree. I have submitted a patch to fix it.

I will close this vote and restart it with a new RC.

Thanks,
Jia

On Wed, May 8, 2024 at 3:17 PM Adam Binford <adam...@gmail.com> wrote:
>
> Looking at the code it looks like the same geopandas issue exists with this
> RC as reported in https://github.com/apache/sedona/issues/1404, if that's
> the case -1 and should probably fix that first?
>
> Adam
>
> On Wed, May 8, 2024 at 11:14 AM Mo Sarwat <themosar...@gmail.com> wrote:
>
> > +1
> >
> > I checked:
> > * Download links are valid
> > * Checksums and PGP signatures are valid
> > * NOTICE is included
> > * Source code artifacts have correct names matching the current release
> > * The project can compile from the source code
> >
> >
> > On Wed, May 8, 2024 at 12:43 AM Jia Yu <ji...@apache.org> wrote:
> >
> > > Hi all,
> > >
> > > This is a call for vote on Apache Sedona 1.6.0-rc2.
> > >
> > > Release notes:
> > >
> > >
> > https://github.com/apache/sedona/blob/sedona-1.6.0-rc2/docs/setup/release-notes.md
> > >
> > > Build instructions:
> > >
> > >
> > https://github.com/apache/sedona/blob/sedona-1.6.0-rc2/docs/setup/compile.md
> > >
> > > GitHub tag:
> > > https://github.com/apache/sedona/releases/tag/sedona-1.6.0-rc2
> > >
> > > GPG public key to verify the Release:
> > > https://downloads.apache.org/sedona/KEYS
> > >
> > > Source code and binaries:
> > > https://dist.apache.org/repos/dist/dev/sedona/1.6.0-rc2/
> > >
> > > The vote will be open for at least 72 hours or until at least 3 "+1"
> > > PMC votes are cast
> > >
> > > Instruction for checking items on the checklist:
> > > https://sedona.apache.org/latest/community/vote/
> > >
> > > We recommend you use this Jupyter notebook on MyBinder to perform this
> > > task:
> > >
> > https://mybinder.org/v2/gh/jiayuasu/sedona-tools/HEAD?labpath=binder%2Fverify-release.ipynb
> > >
> > > **Please vote accordingly and you must provide your checklist for your
> > > vote**.
> > >
> > >
> > > [ ] +1 approve
> > >
> > > [ ] +0 no opinion
> > >
> > > [ ] -1 disapprove with the reason
> > >
> > > Checklist:
> > >
> > > [ ] Download links are valid.
> > >
> > > [ ] Checksums and PGP signatures are valid.
> > >
> > > [ ] Source code artifacts have correct names matching the current
> > release.
> > >
> > > For a detailed checklist  please refer to:
> > >
> > >
> > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> > >
> >
>
>
> --
> Adam Binford

Reply via email to