furqaankhan opened a new pull request, #1415:
URL: https://github.com/apache/sedona/pull/1415

   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor 
Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and 
[Contributor Development 
Guide](https://sedona.apache.org/latest-snapshot/community/develop/)
   
   ## Is this PR related to a JIRA ticket?
   
   - Yes, the URL of the associated JIRA ticket is 
https://issues.apache.org/jira/browse/SEDONA-558. The PR name follows the 
format `[SEDONA-XXX] my subject`
   
   ## Description
   
   ### Current implementation
   
   - Adds the optional parameters `map_style`, and `map_provider` as data 
members to the pdk map object. 
   
        eg: map_p.map_style = map_style
   
   - The current behavior of PyDeck doesn't update the map object with the 
additional configuration added via data members.
   
   ### Behavior of PyDeck
   
   - The default `map_style` is 'dark' and `map_provider` is 'carto'. If you 
configure `map_style` to 'satellite' it will not change the `map_provider` to 
Mapbox or Google Maps API. 
   
   
   ## What changes were proposed in this PR?
   
   - Expose `api_key` parameter of PyDeck
   - If `MAPBOX_API_KEY` env variable is available, it will use it by default.
   - Create a new method to create the PyDeck object to handle the default 
behavior of PyDeck.
   - Default to Mapbox map provider if the `map_style` is set to 'satellite' 
and if `map_provider` is Carto (the default).
   
   ## How was this patch tested?
   
   - Passed existing tests.
   
   ## Did this PR include necessary documentation updates?
   
   - Yes, I have updated the documentation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to