Kontinuation commented on code in PR #1:
URL: https://github.com/apache/sedona-db/pull/1#discussion_r2310106951
##########
rust/sedona-functions/src/sd_format.rs:
##########
@@ -113,39 +97,236 @@ impl SedonaScalarKernel for SDFormatGeometry {
}
}
- let executor = WkbExecutor::new(&arg_types[0..1], &args[0..1]);
+ let formatted_type = sedona_type_to_formatted_type(&arg_types[0])?;
+ if formatted_type == arg_types[0] {
Review Comment:
How can we make sure that the `args` passed in when calling `return_type`
will be identical to `arg_types` passed in when calling `invoke_batch`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
