petern48 opened a new pull request, #2:
URL: https://github.com/apache/sedona-db/pull/2
I've found the use of Datafusion's `internal_err!` to be very misleading
during development because it suggests the error is DataFusion's and not
Sedona's (see the example texts). This PR adds a new macro to use instead.
Example (code was modified to intentionally trigger this internal error):
Before:
```sql
> select st_m(st_geomfromtext('point (1 1)'));
Internal error: unexpected dimension.
This issue was likely caused by a bug in DataFusion's code. Please help us
to resolve this by filing a bug report in our issue tracker:
https://github.com/apache/datafusion/issues
```
Now:
```sql
> select st_m(st_geomfromtext('point (1 1)'));
External error: SedonaDB internal error: unexpected dimension.
This issue was likely caused by a bug in SedonaDB's code. Please help us to
resolve this by filing a bug report in our issue tracker:
https://github.com/apache/sedona-db/issues
```
It would be nice to avoid the "External error:" prepending the message, but
that seems to be the most reasonable of the available options without making an
upstream change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
