> On 三月 24, 2016, 10:04 a.m., Colin Ma wrote: > > Thanks for the patch, I have 2 comments: > > 1. Different versions for datanucleus are included for hive-v1 and hive-v2. > > When package Sentry, the lib will include all these jars, how to avoid the > > conflict? > > 2. test-hive-v1 is enable as default, when do the pre-commit, how to test > > test-hive-v2?
Hi Colin, Here are my comments: 1. Different versions for datanucleus are included for hive-v1 and hive-v2. When package Sentry, the lib will include all these jars, how to avoid the conflict? Currently hive-1 will package, after https://issues.apache.org/jira/browse/SENTRY-589 committed, we can use profile to control package hive-2 or not. 2. test-hive-v1 is enable as default, when do the pre-commit, how to test test-hive-v2? Since we use profile to control the test, we need to create a new Jenkins Job for V2. I will request the permission at community, do you think it is possible to make Jenkins Passed for V1 currently. - Dapeng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45260/#review125178 ----------------------------------------------------------- On 三月 24, 2016, 1:41 p.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45260/ > ----------------------------------------------------------- > > (Updated 三月 24, 2016, 1:41 p.m.) > > > Review request for sentry and Colin Ma. > > > Bugs: SENTRY-1159 > https://issues.apache.org/jira/browse/SENTRY-1159 > > > Repository: sentry > > > Description > ------- > > Since Hive 2.0.0 depends on datanuclues 4+, we should decouple datanuclues > dependence on binding. > > > Diffs > ----- > > pom.xml d25c314 > sentry-binding/sentry-binding-hive/pom.xml fb5f214 > sentry-provider/sentry-provider-db/pom.xml bf4dfdc > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > c5c5ffb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 94bd2a9 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestSentryRole.java > 7b4d3b8 > sentry-tests/pom.xml 88a28bb > sentry-tests/sentry-tests-hive-v2/pom.xml PRE-CREATION > sentry-tests/sentry-tests-hive/pom.xml 472cce7 > sentry-tests/sentry-tests-kafka/pom.xml 54c7205 > sentry-tests/sentry-tests-solr/pom.xml e90ca06 > sentry-tests/sentry-tests-sqoop/pom.xml 3989ced > > Diff: https://reviews.apache.org/r/45260/diff/ > > > Testing > ------- > > > Thanks, > > Dapeng Sun > >
