> On March 21, 2016, 7:20 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java, > > line 76 > > <https://reviews.apache.org/r/44501/diff/3/?file=1308063#file1308063line76> > > > > What happens if user uses SSL but does not set keystore path or > > password in the conf file?
the sentry service will still work, except the webpage. > On March 21, 2016, 7:20 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java, > > line 77 > > <https://reviews.apache.org/r/44501/diff/3/?file=1308063#file1308063line77> > > > > nit: intend here and below as well Sure. Thanks Sravya! > On March 21, 2016, 7:20 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java, > > line 167 > > <https://reviews.apache.org/r/44501/diff/3/?file=1308064#file1308064line167> > > > > Add a comment on why these are blacklisted? Sure. Thanks Sravya! On March 21, 2016, 7:20 p.m., Li Li wrote: > > Thanks for fixing this Li! Some minor comments. Also, wondering about the > > test coverage. I believe it might be tricky to test this without setting up > > keystore, any thoughts? Thanks for your remind! Yes, we need generate a keystore and trustStore. I will add test in the next patch. - Li ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44501/#review124624 ----------------------------------------------------------- On March 21, 2016, 4:43 a.m., Li Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44501/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 4:43 a.m.) > > > Review request for sentry, Anne Yu, Hao Hao, Lenni Kuff, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Add SSL support, print version info on Sentry Service webpage > > > Diffs > ----- > > sentry-provider/sentry-provider-db/pom.xml > 1dbfad49f7b9bb1b963221600bbd8d0400ab8d5d > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java > 1bdea2c55de12a999f94ea33f8709311c7c2c7f2 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 94bd2a95c77a9691cbaa578ebf417e49c339b7ed > sentry-provider/sentry-provider-db/src/main/webapp/SentryService.html > ee112ce8d39626784d5d73ef0a4c28f43e7c4f1f > sentry-provider/sentry-provider-db/src/main/webapp/css/sentry.css > e5b3d437406a881e78494547791e1b26bb4f2bc8 > > Diff: https://reviews.apache.org/r/44501/diff/ > > > Testing > ------- > > > Thanks, > > Li Li > >
