> On March 31, 2016, 7:06 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestConcurrentClients.java, > > line 323 > > <https://reviews.apache.org/r/45502/diff/1/?file=1319887#file1319887line323> > > > > Will the URI scheme be changed later? Should we get it from the > > filesystem config?
yeah, will change this line to make it flexible. > On March 31, 2016, 7:06 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperations.java, > > line 1098 > > <https://reviews.apache.org/r/45502/diff/1/?file=1319889#file1319889line1098> > > > > Why add scheme again if the dir starts with s3? There is a not in the front. So if there is no scheme in the front will add it. - Anne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45502/#review126407 ----------------------------------------------------------- On March 30, 2016, 7:20 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45502/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 7:20 p.m.) > > > Review request for sentry and Hao Hao. > > > Bugs: sentry-1164 > https://issues.apache.org/jira/browse/sentry-1164 > > > Repository: sentry > > > Description > ------- > > 1. Fix one test failure in > org.apache.sentry.tests.e2e.dbprovider.TestDbOperations.testCaseSensitivity; > 2. Improve TestConcurrentClients to be able to run locally; also add more > validation logics. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestConcurrentClients.java > bf871f01a8cdc0bab3e502c4fbdbee9285b8437b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > b96175797dfc8bf238722b6177a7800d569b7e8a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperations.java > 7d3db2b135d3239410bb664dbf7aed5817ee01c0 > > Diff: https://reviews.apache.org/r/45502/diff/ > > > Testing > ------- > > Passed precommit build. > > > Thanks, > > Anne Yu > >
