----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34080/#review126509 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java (line 85) <https://reviews.apache.org/r/34080/#comment189514> Can we follow the same format pattern to change line at the first parameter? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java (line 100) <https://reviews.apache.org/r/34080/#comment189515> The same format: new line at the first parameter to be consistent with the code in the same block. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java (line 224) <https://reviews.apache.org/r/34080/#comment189516> Can this code block put after the group related code block? It seems that we follow a pattern to add the code for user after the group. But this time is reverse? - Jerry Chen On May 12, 2015, 6:57 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34080/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 6:57 a.m.) > > > Review request for sentry, Dapeng Sun, shen guoquan, and Prasad Mujumdar. > > > Repository: sentry > > > Description > ------- > > Update audit log for grant user to role > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java > 90308f4 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java > 9beef83 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java > 072a0e8 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java > 0a2b0b2 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java > 2cecdfd > > Diff: https://reviews.apache.org/r/34080/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
