----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45728/#review127038 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift (line 244) <https://reviews.apache.org/r/45728/#comment190170> My oppinion authObjectFilter is not quite a good name here. Naming suggestions: objectName objectPath - Jerry Chen On April 5, 2016, 3:53 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45728/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 3:53 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Update thrift API for export with specific auth object > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataRequest.java > 8145252 > > sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift > 40889e8 > > Diff: https://reviews.apache.org/r/45728/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
