----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45727/#review127056 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 2054) <https://reviews.apache.org/r/45727/#comment190198> For code logic like this, early return will keep the less levels of code blocks. if(mSentryRoles == null) { return groupRolesMap; } will help. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 2113) <https://reviews.apache.org/r/45727/#comment190200> Please early return if null to keep the indent depth minimum. - Jerry Chen On April 5, 2016, 6:48 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45727/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 6:48 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Update SentryStore for export with specific auth object > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > dbb5d8e > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java > a9e4ed6 > > Diff: https://reviews.apache.org/r/45727/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
