> On 四月 8, 2016, 7:55 a.m., Jerry Chen wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java, > > line 694 > > <https://reviews.apache.org/r/34086/diff/5/?file=1332223#file1332223line694> > > > > In concept, we may don't need to list the roles for the groups of the > > user. > > > > The command is to list the roles directly assigned to the user.
Agree, also update https://reviews.apache.org/r/34079/ > On 四月 8, 2016, 7:55 a.m., Jerry Chen wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java, > > line 680 > > <https://reviews.apache.org/r/34086/diff/5/?file=1332223#file1332223line680> > > > > I saw the similar method for group, there is client version check as > > following: > > > > validateClientVersion(request.getProtocol_version()); > > > > Is this necessary for this method? Thank you for your comments, I have fixed it. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34086/#review127748 ----------------------------------------------------------- On 四月 8, 2016, 9:20 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34086/ > ----------------------------------------------------------- > > (Updated 四月 8, 2016, 9:20 a.m.) > > > Review request for sentry, Dapeng Sun and Jerry Chen. > > > Repository: sentry > > > Description > ------- > > Update SentryPolicyStoreProcessor for grant user to role > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > de50adb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > edc5661 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 8881d82 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerForHaWithoutKerberos.java > ac4df77 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerWithoutKerberos.java > 0792eb6 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java > 07c7f7a > > Diff: https://reviews.apache.org/r/34086/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
