----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46548/#review130181 -----------------------------------------------------------
Ship it! Ship It! - Vamsee Yarlagadda On April 22, 2016, 12:58 a.m., Gregory Chanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46548/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 12:58 a.m.) > > > Review request for sentry, Sravya Tirukkovalur and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > When testing the tool from SENTRY-480 on a kerberos cluster I ran into a > couple of small bugs: > 1) The client is created after the UGI is returned, so may be out of date > 2) The compat checker always throws an exception; this exception will list > zero errors, but it would cleaner if it only threw exceptions on errors. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryConfigToolSolr.java > bf91f5260312644a15735a2174e88d5a0e5e61b6 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryConfigToolSolr.java > 7149f17ae11b96fad279a652a2ea7d7848e97d59 > > Diff: https://reviews.apache.org/r/46548/diff/ > > > Testing > ------- > > Ran the new test. > > > Thanks, > > Gregory Chanan > >
