----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46909/ -----------------------------------------------------------
(Updated May 6, 2016, 5:08 p.m.) Review request for sentry, Dapeng Sun, Gregory Chanan, Hao Hao, and Sravya Tirukkovalur. Changes ------- Address review comments. 1. Remove filterByAthorizables and punt it to a follow up JIRA. 2. Remove changes from thrift generated file. 3. Rename sentry.service.client.caching to sentry.service.client.cache.enabled Bugs: SENTRY-1229 https://issues.apache.org/jira/browse/SENTRY-1229 Repository: sentry Description ------- SENTRY-1229: Add caching to SentryGenericProviderBackend. Diffs (updated) ----- sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ProviderBackend.java ffd3af4903dd59f37ea1ff4a55138742fdfa74da sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java 222b6fd530a0e26ea625d1be0fd68b0828558316 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/Updatable.java PRE-CREATION sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java PRE-CREATION sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClient.java 60502895a0fcdd781f5bd61b29a676a7c96f81b8 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java dce3dade7f42fe35a849612c5caf2e98d2dac578 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 00e3fbde76ebf84704ee110adfca30869845a7b8 sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java a2cfa28da2af548a872ec0d2e5620ae1c27041b3 sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/TestAuthorize.java 250522ed33394a667b1a0d6c47c68b210e0214a3 Diff: https://reviews.apache.org/r/46909/diff/ Testing ------- Extended Kafka e2e tests. Will be running perf tests for Kafka-Sentry integration with caching turned on. Thanks, Ashish Singh