> On May 10, 2016, 7:12 a.m., Dapeng Sun wrote: > > Thank Ashish for your contribution!
Thanks for the review Dapeng! Mind giving it another pass? > On May 10, 2016, 7:12 a.m., Dapeng Sun wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConvertor.java, > > line 55 > > <https://reviews.apache.org/r/47075/diff/1/?file=1374985#file1374985line55> > > > > Do we need to test if we covered the case, likes > > "CLUSTER=kafka-cluster->HOST=*->action=write" which resource type is in > > front of HOST? It is covered in testNegativeCaseWithInvalidArgument. In case you are referring to some other scenario let me know. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47075/#review132383 ----------------------------------------------------------- On May 6, 2016, 5:54 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47075/ > ----------------------------------------------------------- > > (Updated May 6, 2016, 5:54 p.m.) > > > Review request for sentry, Colin Ma and Dapeng Sun. > > > Bugs: SENTRY-1208 > https://issues.apache.org/jira/browse/SENTRY-1208 > > > Repository: sentry > > > Description > ------- > > SENTRY-1208: Make HOST implied in privileges if not specified explicitly. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConvertor.java > af73755ae92ad4f61243d18b2521d144189532b4 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellKafka.java > d49bc57b5c0b619e5e0e34fcf1f2676535c9e13c > > Diff: https://reviews.apache.org/r/47075/diff/ > > > Testing > ------- > > Extended existing unit tests. > > > Thanks, > > Ashish Singh > >
