----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47566/ -----------------------------------------------------------
Review request for sentry, Sravya Tirukkovalur and Vamsee Yarlagadda. Repository: sentry Description ------- Rename Convertor->Converter consistently. Also sets the converter by default in the SolrAuthzBinding so it doesn't need to be explicitly set. Diffs ----- sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java 24e5172d82978c35c83bb7b6eb0b98bb8223fa5b sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java 6de0a54d3bca995429b0b088448973be6c8bfafe sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java ccb349b4d2cacf80cdac8dea877a2a091da35826 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConverter.java PRE-CREATION sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConvertor.java 902895d62c411da2a1e3ac94f1c51aca56b7f6de sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryConfigToolSolr.java 040680707ad31f3b08e986698b373218b9e84976 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellKafka.java 0e408822acee17b01c08215811e7b251172a4ce5 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellSolr.java de718e963b384f24bb1ea9fb8509b5785cee813a sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConverter.java PRE-CREATION sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConvertor.java 29250c4a0710e1da5ec661613e7b29c5672c88b7 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/GrantPrivilegeToRoleCmd.java 586798360e654b6bd3494bb5d89b3c2a64eeda6f sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/ListPrivilegesByRoleCmd.java 8420291a90607c2259f9c2cb8b4f5f3482b19ad5 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/RevokePrivilegeFromRoleCmd.java fba17e62ba0f6838739c5db74ee5e57928221f74 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/TSentryPrivilegeConverter.java PRE-CREATION sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/TSentryPrivilegeConvertor.java f8723412f63c4b6bae2dec398499166aa4244f56 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryConfigToolSolr.java 51679de09e8cc56ca7da3b5d356db57c946dfcf6 sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java c4e38637f195c88a95f641fc752c30b7c2e36e02 Diff: https://reviews.apache.org/r/47566/diff/ Testing ------- Ran the sentry-provider-db unit tests. Thanks, Gregory Chanan
