> On May 21, 2016, 5:58 a.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/TestHiveWarehouseOnExtFs.java, > > line 57 > > <https://reviews.apache.org/r/47682/diff/1/?file=1390156#file1390156line57> > > > > Is this test specific for s3 only?
Yeah, so far it's s3a. Once we can test Azure will add more conditions. Not sure that scheme will be used here. HDFS filesystem doesn't need to run this test since we already have so many in the dbprovider e2e. > On May 21, 2016, 5:58 a.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/TestTableOnExtFS.java, > > line 73 > > <https://reviews.apache.org/r/47682/diff/1/?file=1390157#file1390157line73> > > > > Could you add some test for location URI without scheme and authority? ok, will add one. - Anne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47682/#review134234 ----------------------------------------------------------- On May 21, 2016, 12:23 a.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47682/ > ----------------------------------------------------------- > > (Updated May 21, 2016, 12:23 a.m.) > > > Review request for sentry, Hao Hao, Lenni Kuff, and Sean Mackrory. > > > Bugs: SENTRY-1230 > https://issues.apache.org/jira/browse/SENTRY-1230 > > > Repository: sentry > > > Description > ------- > > SENTRY-1230: Add filesystem tests to test Sentry with user data storage on > S3. The tests can also be run on other types of fileSystems (ms azure, hdfs). > Just ensure pass correct parameters. > For example, > -Dsentry.e2etest.DFSType=S3DFS > -Dsentry.e2etest.storage.uri=s3a://sentry-s3 > -Dfs.s3a.access.key=a > -Dfs.s3a.secret.key=s > export HIVE_CONF_DIR=/etc/hive/conf/hite-site.xml > > > Diffs > ----- > > pom.xml a82c66d9a730c76403600b12db7563522d6c12be > sentry-tests/sentry-tests-hive/pom.xml > e36b5c04d48b3211abaecd36bf2673e6304bdc31 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestDbHdfsBase.java > 001f5a49449112785cf129bfeda22c3bdf8cf3a6 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 0e4b3cab7685937e563b971274c66be43ba88fc1 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/AbstractDFS.java > 32aabb41a1fef486ebed80571f0bd96e4c7c3c3c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/ClusterDFS.java > 06415cb828bfc6408bdc74d57c352ccfd55b7b43 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/DFS.java > 67ba3386df6f52c1cd21d47eaec58a1a467bebcb > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/DFSFactory.java > 7f650ceb01d6325c2dea794a207baaa5a4cb6e73 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/S3DFS.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/TestFSBase.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/TestFSContants.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/TestHiveWarehouseOnExtFs.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/TestTableOnExtFS.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/AbstractHiveServer.java > dda7dba662f7ba8fb9f705066c4bc680a7358f50 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/EmbeddedHiveServer.java > 52ba09e5e1006ff44a5073bce412ddee0774b24b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServer.java > 175e84ceac8f24c1faa905d02daac1739e17f320 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/InternalHiveServer.java > 45f0ef28bc2393c16dd385cd8e37c133302b2993 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/UnmanagedHiveServer.java > beae8e83bc9895f9c3aafd2eb9c6320b11ad0c1d > > Diff: https://reviews.apache.org/r/47682/diff/ > > > Testing > ------- > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.sentry.tests.e2e.hive.fs.TestHiveWarehouseOnExtFs > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 45.419 sec - > in org.apache.sentry.tests.e2e.hive.fs.TestHiveWarehouseOnExtFs > > Results : > > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:28.585s > [INFO] Finished at: Fri May 20 17:09:38 PDT 2016 > [INFO] Final Memory: 60M/825M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Anne Yu > >
