----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48515/#review136902 -----------------------------------------------------------
Ship it! Thanks for the fix Vihang! Hopefully, these subtle ast issues will be resolved for good once we move to Hive V2. - Sravya Tirukkovalur On June 9, 2016, 9:39 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48515/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 9:39 p.m.) > > > Review request for sentry, Hao Hao and Sravya Tirukkovalur. > > > Bugs: SENTRY-1320 > https://issues.apache.org/jira/browse/SENTRY-1320 > > > Repository: sentry > > > Description > ------- > > Precondition check in PreAnalyze() expects only one child node in the ASTNode > for truncate query. But it is possible to have two children nodes when the > query is of the form truncate table db_name.table_name; Hive queries doing > this way to truncate the table fails will IllegalArgumentException during to > Precondition check violation. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > a13ab7918d8900f7dd83054f186b1fc0a04602c0 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScopePart2.java > 3b5f6a6b593b281f7c6a34c5157d4dd929fa97bd > > Diff: https://reviews.apache.org/r/48515/diff/ > > > Testing > ------- > > Ran the updated test TestPrivilegesAtTableScopePart2 successfully. > > > Thanks, > > Vihang Karajgaonkar > >
