----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48307/#review137246 -----------------------------------------------------------
Thank Ke, I left some comments. sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java (line 222) <https://reviews.apache.org/r/48307/#comment202412> Better to make **tableEvent.getOldTable() ** as a variable sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java (line 223) <https://reviews.apache.org/r/48307/#comment202413> Better to check null dereference dereference for getSd(). - Dapeng Sun On 六月 7, 2016, 10:26 a.m., Ke Jia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48307/ > ----------------------------------------------------------- > > (Updated 六月 7, 2016, 10:26 a.m.) > > > Review request for sentry, Colin Ma and Dapeng Sun. > > > Bugs: SENTRY-1094 > https://issues.apache.org/jira/browse/SENTRY-1094 > > > Repository: sentry > > > Description > ------- > > SentryMetastorePostEventListener.onAlterTable should check for null > dereference. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java > d12ac15 > > Diff: https://reviews.apache.org/r/48307/diff/ > > > Testing > ------- > > All Test Passed > > > Thanks, > > Ke Jia > >
