----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48316/#review137251 -----------------------------------------------------------
Thank Ke, I left some comments. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java (line 245) <https://reviews.apache.org/r/48316/#comment202419> better return a empty role set here sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java (line 2022) <https://reviews.apache.org/r/48316/#comment202418> Better to add test to verify if the result is empty - Dapeng Sun On 六月 7, 2016, 1:07 p.m., Ke Jia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48316/ > ----------------------------------------------------------- > > (Updated 六月 7, 2016, 1:07 p.m.) > > > Review request for sentry, Colin Ma and Dapeng Sun. > > > Bugs: SENTRY-320 > https://issues.apache.org/jira/browse/SENTRY-320 > > > Repository: sentry > > > Description > ------- > > show role grant group groupname should not throw an exception if group doesnt > exist in db > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > 1039e6e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java > a7c0a0c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestGrantUserToRole.java > 4ce30c1 > > Diff: https://reviews.apache.org/r/48316/diff/ > > > Testing > ------- > > All test passed > > > Thanks, > > Ke Jia > >
