----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48660/#review137367 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java (line 123) <https://reviews.apache.org/r/48660/#comment202508> One important comment: wondering if there is going to be another cr to expose getIsActiveGauge and getIaHAGauge to any external app. External app doesn't have handle for sentry server. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java (line 1728) <https://reviews.apache.org/r/48660/#comment202509> Can also add an e2e test case on a real cluster like, http://github.mtv.cloudera.com/CDH/sentry/blob/cdh5-1.5.1/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestDbHdfsExtMaxGroups.java. In that case, can sort of understanding how on unmanaged cluster, client gets to know the information. - Anne Yu On June 13, 2016, 6:52 p.m., Rahul Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48660/ > ----------------------------------------------------------- > > (Updated June 13, 2016, 6:52 p.m.) > > > Review request for sentry, Colin McCabe and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > SENTRY-1319:Add metrics for isActive and isHA > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java > c6d4d02fd77f4f9a31ea802c497fa23281bf7a75 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 578364933a3cdcf6c142b836360a83d322fe5c11 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 1606b6d97c6696328906100eb10464fdc2fa19e8 > > Diff: https://reviews.apache.org/r/48660/diff/ > > > Testing > ------- > > > Thanks, > > Rahul Sharma > >
