----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48736/#review137797 -----------------------------------------------------------
Ship it! Would be good to add a kerberos end to end test to access metrics, as sentry's clients (kerberos clients) would be accessing it now. We can do that as a follow on jira. See TestSentryServiceWithKerberos.java for a trivial example. - Sravya Tirukkovalur On June 15, 2016, 5:10 p.m., Rahul Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48736/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 5:10 p.m.) > > > Review request for sentry, Anne Yu and Colin McCabe. > > > Repository: sentry > > > Description > ------- > > SENTRY-1319: Made changes as per Colin's comments. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java > c6d4d02fd77f4f9a31ea802c497fa23281bf7a75 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 578364933a3cdcf6c142b836360a83d322fe5c11 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceMetrics.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 1606b6d97c6696328906100eb10464fdc2fa19e8 > > Diff: https://reviews.apache.org/r/48736/diff/ > > > Testing > ------- > > > Thanks, > > Rahul Sharma > >
