----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48746/ -----------------------------------------------------------
Review request for sentry, Colin McCabe and Nachiket Vaidya. Repository: sentry Description ------- Adding tests to use the NotificationLog of Hive as is. Diffs ----- sentry-tests/sentry-tests-hive/pom.xml 02bfa49c9513a36a93017c706375bf58d063d7d7 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java ced9d1c0848abe7f384d8247e0a1571d6a0ef139 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java 847da45dcc884d7d573b10a18d3122292754c8ad sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java f1e6d75b2ae8e20343ff49bd46ef254ed6320ad4 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java PRE-CREATION Diff: https://reviews.apache.org/r/48746/diff/ Testing ------- - Added tests for all DDLs which change(or add/delete) <Obj,location> mapping in HMS. - Make sure event id is monotonically increasing. - Commented out some tests which fail on plain vanilla Hive 1.1.0. We can enable these either after we move to Hive 1.2.0 or after SENTRY-1329, which has a fix within Sentry - which ever happens sooner. Thanks, Sravya Tirukkovalur
