> On June 28, 2016, 1:28 a.m., Kapil Rastogi wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java, > > lines 1835-1836 > > <https://reviews.apache.org/r/49290/diff/2/?file=1431344#file1431344line1835> > > > > Rename will move the directory essentially. How does 'recreating' and > > 'validating' useful here? > > > > Would it make sense to assert that the directory for 'tableName' > > doesn't exist anymore.
If a user creates a new directory here, he should not see ACLS which existed on this deleted table. > On June 28, 2016, 1:28 a.m., Kapil Rastogi wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java, > > line 1873 > > <https://reviews.apache.org/r/49290/diff/2/?file=1431344#file1431344line1873> > > > > missing location for external table? same for next two (partitioned > > table with/without partitions)? external table or unmanaged table as I am referring here, does not necessarily need to have an explicit location. In which case it will be created in the default location. But it would still be unmanaged, that is, if you drop the table, contents will not be dropped. - Sravya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49290/#review139706 ----------------------------------------------------------- On June 28, 2016, 12:27 a.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49290/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 12:27 a.m.) > > > Review request for sentry, Anne Yu, Hao Hao, Kapil Rastogi, Lenni Kuff, and > Sergio Pena. > > > Repository: sentry > > > Description > ------- > > Adding test cases for rename table. Details are in the test class itself. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > b1d507f591323e08e0d0a0384a4525ad8b66af0c > > Diff: https://reviews.apache.org/r/49290/diff/ > > > Testing > ------- > > > Thanks, > > Sravya Tirukkovalur > >
