> On July 1, 2016, 5:31 p.m., Anne Yu wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java, > > line 633 > > <https://reviews.apache.org/r/49491/diff/1/?file=1434660#file1434660line633> > > > > Can you also try to add one test for Create View AS SELECT; > > > > create table db_1.tb1(int id, string val, int num); > > ... > > > > use db_1; > > create view db_1.v1 as select db_1.tb1.id, db_2.tb1.num, db_2.tb2.val > > from db_1.tb1, db_2.tb1, db_2.tb2; (the syntax might be incorrect please > > modify as needed) > > Anne Yu wrote: > Can you also insert some data into each of tables and select * from view > to assert data are correctly inserted. Can this test case be also run in > dbprovider profile on a real cluster? > > Ke Jia wrote: > Hi Anne Yu, Whether the "dbprovider profile" is a profile of maven? Now, > I updated the patch, but I don't know how run it in dbprovider profile on a > real cluster.
Oh, as long as the test is included into "dbprovider profile" is able to run it. What I meant is ensure it's included into that profile. - Anne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49491/#review140387 ----------------------------------------------------------- On July 1, 2016, 5:15 a.m., Ke Jia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49491/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 5:15 a.m.) > > > Review request for sentry, Anne Yu and Dapeng Sun. > > > Bugs: SENTRY-1334 > https://issues.apache.org/jira/browse/SENTRY-1334 > > > Repository: sentry > > > Description > ------- > > test and add test for CTAS and Create View AS SELECT (cross databases cases) > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java > b123dcd > > Diff: https://reviews.apache.org/r/49491/diff/ > > > Testing > ------- > > test done > > > Thanks, > > Ke Jia > >
