> On July 8, 2016, 6:04 p.m., Sravya Tirukkovalur wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/Fencer.java,
> > line 135
> > <https://reviews.apache.org/r/49738/diff/3/?file=1439071#file1439071line135>
> >
> > Why rollback? What does roll back mean for read only queries? Is it
> > still recommended to commit the transaction?
>
> Colin McCabe wrote:
> While it is true that this is a read-only transaction, rollback is still
> required to terminate the transaction. Otherwise, later we will receive the
> error "javax.jdo.JDOUserException: Transaction is still active. You should
> always close your transactions correctly using commit() or rollback()." See
> this link for more information:
> http://stackoverflow.com/questions/4418317/jdo-exception-in-google-app-engine-transaction
Thanks for the info Colin! Yes, I agree that we should commit for read only
transactions as well, and hence I was curious why there is no commit. But
rather we just have
if (tx.isActive()) {
tx.rollback();
}
Where it will always be active, as we have not made an attempt to commit.
- Sravya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49738/#review141285
-----------------------------------------------------------
On July 8, 2016, 7:59 p.m., Colin McCabe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49738/
> -----------------------------------------------------------
>
> (Updated July 8, 2016, 7:59 p.m.)
>
>
> Review request for sentry, Hao Hao, Rahul Sharma, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-1317
> https://issues.apache.org/jira/browse/SENTRY-1317
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1317: Implement fencing required for active/passive
>
>
> Diffs
> -----
>
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryStandbyException.java
> PRE-CREATION
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryConstants.java
> 3da4906
>
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PluginCacheSyncUtil.java
> 4ce16c7
>
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHdfsMetricsUtil.java
> 5bf2f6e
>
> sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestHAUpdateForwarder.java
> 5246e05
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/Fencer.java
> PRE-CREATION
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java
> cacc29f
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
> 7dad496
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceRegister.java
> 79dfe48
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SqlAccessor.java
> PRE-CREATION
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java
> 3de1f65
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/Activator.java
> PRE-CREATION
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/Activators.java
> PRE-CREATION
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatus.java
> e846766
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusAdaptor.java
> 80a6571
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java
> 809af06
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java
> 0ab8192
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java
> f14b586
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java
> 799d5ef
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
> 3ef1cf7
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java
> 3ff97df
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryVersion.java
> a8e8a03
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java
> cb2d9c9
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestLeaderStatus.java
> 434ac41
>
> Diff: https://reviews.apache.org/r/49738/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin McCabe
>
>
