----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49996/#review142297 -----------------------------------------------------------
Fix it, then Ship it! Thanks Colin! +1 with minor comments. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java (line 90) <https://reviews.apache.org/r/49996/#comment207879> Do we also need verify active for the following APIs? e.g. alterRoleGrantPrivilege, renamePrivilege, etc.? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/Fencer.java (line 233) <https://reviews.apache.org/r/49996/#comment207869> It looks like this API is to verify by using select query. Not quite match the comments here? - Hao Hao On July 13, 2016, 6:28 p.m., Colin McCabe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49996/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 6:28 p.m.) > > > Review request for sentry, Hao Hao and Sravya Tirukkovalur. > > > Bugs: SENTRY-1399 > https://issues.apache.org/jira/browse/SENTRY-1399 > > > Repository: sentry > > > Description > ------- > > SENTRY-1399: Integrate Fencer with SentryStore > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryStandbyException.java > 73c7e4e > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > e960dcd > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java > c003965 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/Fencer.java > 14cdde3 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 6e367e5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/Activator.java > 0b7ddf5 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestFencer.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 6e00505 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java > fc39658 > > Diff: https://reviews.apache.org/r/49996/diff/ > > > Testing > ------- > > > Thanks, > > Colin McCabe > >
