----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50474/#review144051 -----------------------------------------------------------
Thanks Haohao. Left some minor comments here. sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationConstants.java (line 32) <https://reviews.apache.org/r/50474/#comment210029> Minor issues: white spaces. sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java (line 75) <https://reviews.apache.org/r/50474/#comment210035> Just want to enforce defensive coding, pathElems != null && pathElems.length > 1 ... sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java (line 156) <https://reviews.apache.org/r/50474/#comment210143> Will it be possible prefixPath contains the same items with different order from pathElements? sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java (line 198) <https://reviews.apache.org/r/50474/#comment210144> Better add some comments for each condition branch to state which case it is trying to handle. Roughtly seems could be 6 cases+/-. It will help maintain codes and support escalations. sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java (line 332) <https://reviews.apache.org/r/50474/#comment210148> pathElements != null && ... sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java (line 1967) <https://reviews.apache.org/r/50474/#comment210152> Not sure if the other group/user's rwx should be set by sentry privileges or just hard set by test? - Anne Yu On July 26, 2016, 11:41 p.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50474/ > ----------------------------------------------------------- > > (Updated July 26, 2016, 11:41 p.m.) > > > Review request for sentry and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Use the new INodeAttributesProvider API in sentry-hdfs > > > Diffs > ----- > > pom.xml a4f2bcc14855a2e5f712f9c56fbdb1e137edfa93 > sentry-binding/sentry-binding-solr/pom.xml > 8b94c87118841c2ce775c3e79ff6bb43ba5185fd > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/hadoop/hdfs/server/namenode/AuthorizationProvider.java > 383d64d88c74c93cd79ccb189301b9c1a6d919e4 > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationConstants.java > 883680182fd01f4b0b1a7fb5d8eb4d7f23f5851e > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationProvider.java > f639f5fbacc85b2adb757087c2eba66b092743a2 > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java > PRE-CREATION > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/MockSentryAuthorizationProvider.java > 2085b525db0b7a9fda77a4be62026da3bf74b7ac > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/TestSentryAuthorizationProvider.java > 5da0dc2fb4a47098bd5f9b36dbacb0296162f95b > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 60085b20774fb28c978f60b97bbef0ecbadb8d8f > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 25d13d62a1a16beba16ae46fbd28f2490fca10bc > > Diff: https://reviews.apache.org/r/50474/diff/ > > > Testing > ------- > > > Thanks, > > Hao Hao > >
