----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51168/ -----------------------------------------------------------
Review request for sentry, Dapeng Sun and Sravya Tirukkovalur. Repository: sentry Description ------- We might be able to just use PoolClientInvocationHandler in SentryGenericServiceClientFactory. This way, we get the StandbyException handling needed for Sentry HA support for Generic model clients. Diffs ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java ee6cdf7 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientFactory.java 980d930 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientPoolFactory.java PRE-CREATION sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java 353d461 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java 9e90af8 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientPoolFactory.java 0164fa6 Diff: https://reviews.apache.org/r/51168/diff/ Testing ------- Thanks, Colin Ma
