> On Oct. 7, 2016, 6:03 p.m., Li Li wrote: > >
Thank you for the review. > On Oct. 7, 2016, 6:03 p.m., Li Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/RulesForE2ETest.java, > > line 29 > > <https://reviews.apache.org/r/52582/diff/1/?file=1523454#file1523454line29> > > > > It is better to add some some comment for the new class and vars in it. Yeah, for public class we should do it. Will add. > On Oct. 7, 2016, 6:03 p.m., Li Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/RulesForE2ETest.java, > > line 44 > > <https://reviews.apache.org/r/52582/diff/1/?file=1523454#file1523454line44> > > > > also 'description != null' ? Will add. > On Oct. 7, 2016, 6:03 p.m., Li Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/RulesForE2ETest.java, > > line 45 > > <https://reviews.apache.org/r/52582/diff/1/?file=1523454#file1523454line45> > > > > add debug log for the SlowE2ETest case showing the timeout used? will add. > On Oct. 7, 2016, 6:03 p.m., Li Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/RulesForE2ETest.java, > > line 47 > > <https://reviews.apache.org/r/52582/diff/1/?file=1523454#file1523454line47> > > > > use final static var for all the timeout? will add. - Anne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52582/#review151832 ----------------------------------------------------------- On Oct. 5, 2016, 11:33 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52582/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 11:33 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Li Li, and Sravya > Tirukkovalur. > > > Bugs: SENTRY-1489 > https://issues.apache.org/jira/browse/SENTRY-1489 > > > Repository: sentry > > > Description > ------- > > org.apache.sentry.tests.e2e.dbprovider.TestDbCrossOperations and some other > tests occasionally fail with time out exception. Should make a more flexible > rule for different type of tests. By nature, some tests just take longer time > to finish. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java > e7cccbfb7955a497f485e3b69e9dc4d9db191473 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbCrossOperations.java > 60812cfa82d318ddfad32e439d3895f49ed21180 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithHiveServer.java > a314c0dde9c60e7dbb51156cea13980bf8600bf1 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 62da0256e8546a25f0ed0a97b8f3c21eec4fecaa > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/RulesForE2ETest.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/SlowE2ETest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52582/diff/ > > > Testing > ------- > > > Thanks, > > Anne Yu > >
