> On Oct. 10, 2016, 11:33 p.m., Li Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java, > > line 102 > > <https://reviews.apache.org/r/52675/diff/1/?file=1529190#file1529190line102> > > > > what's the meaning of managed table?
managed table: managed by hive, when drop it's HDFS dirs/files will be dropped as well, by default created under /user/hive/warehouse, user can also specify location; external table: managed by user, when drop it's HDFS dirs/files will be kept, user specify location to let the table store data in that dir. http://stackoverflow.com/questions/17038414/difference-between-hive-internal-tables-and-external-tables > On Oct. 10, 2016, 11:33 p.m., Li Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java, > > line 119 > > <https://reviews.apache.org/r/52675/diff/1/?file=1529190#file1529190line119> > > > > since KEYTAB_LOCATION is hdfs keytab, we'd better add hdfs in the > > config name. Or we can add another config for the run as user which is hdfs > > by default it's a keytab dir stores all system or user keytab files, can be used by hdfs, hive, hbase and others. > On Oct. 10, 2016, 11:33 p.m., Li Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java, > > line 208 > > <https://reviews.apache.org/r/52675/diff/1/?file=1529190#file1529190line208> > > > > what is seq? > > what if NUM_OF_DATABASES_PER_THREAD - seq - 1 == 0? seq is index ranging from 0 to a constant number. will add condition to check it. - Anne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52675/#review152076 ----------------------------------------------------------- On Oct. 10, 2016, 11:44 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52675/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 11:44 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Li Li, and Sravya > Tirukkovalur. > > > Bugs: SENTRY-1497 > https://issues.apache.org/jira/browse/SENTRY-1497 > > > Repository: sentry > > > Description > ------- > > Specify the scale numbers like databases, tables, views, partitions, columns, > uris, privileges, role, and groups in a config file, the tool can create such > volume of data in Sentry and HMS databases. To speed up test, it can also do > the task parallelly. > > > Diffs > ----- > > sentry-tests/sentry-tests-hive/pom.xml > a2512ee3919a3958425f4ab74b178d02e0402315 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/UnmanagedHiveServer.java > 90713b1aaa688808859e670c8799f8e5be2d6d26 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/TestTools.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/sentry_scale_test_config.xml > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/scripts/scale-test/create-many-dbs-tables.sh > dcdddeb95a896ca8470d0b994f5460531e34d113 > > Diff: https://reviews.apache.org/r/52675/diff/ > > > Testing > ------- > > > Thanks, > > Anne Yu > >
