----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52526/ -----------------------------------------------------------
(Updated Nov. 2, 2016, 6:08 p.m.) Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, and Sravya Tirukkovalur. Changes ------- Addressed Alexander's comments Repository: sentry Description ------- Since currently non pool model is used for sentry clients, here update retry logic for non-pool model. For each full retry we will cycle through all available sentry servers randomly. After each full retry, we will have a small random sleep. Diffs (updated) ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java 4f42a51b1449fe15f856ba252103e66383e175d7 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/ThriftUtil.java 3a96d0b124c00efc99cef256c72c25f5c6168007 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java 730bfec98a78ac11f1fae8ab84f9e6715e802a40 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/RetryClientInvocationHandler.java PRE-CREATION sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryClientInvocationHandler.java a41be7fea2c77d0e1f0bbec3e215a33c2cd89417 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java b7d2be153576f80aa1c0fd230d29523cf6a047c3 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java a2499040d77dbeb9925a529063fd6a492dd57cc4 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestPoolClientInvocationHandler.java 5b0e12bbf12510d8d424aa2b7f51076a913234c5 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java 3f57a003903961a6aea98bd583a14b65bd2b98a2 Diff: https://reviews.apache.org/r/52526/diff/ Testing ------- Tested in my dev with the following cases: 1. one server is down before client connection 2. one server is down after client connection and during client request Thanks, Li Li
