----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53921/#review156413 -----------------------------------------------------------
Fix it, then Ship it! Ship It! sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java (line 150) <https://reviews.apache.org/r/53921/#comment226619> Defining "default" clause in "switch" statement is always a good idea. Besides possibility of adding new Reporting enum value, null can be passed by mistake. - Vadim Spector On Nov. 19, 2016, 2:52 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53921/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2016, 2:52 a.m.) > > > Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, and Vadim > Spector. > > > Repository: sentry > > > Description > ------- > > SENTRY-1533: Sentry console metrics reporting interval should be configurable > > > Diffs > ----- > > > sentry-service/sentry-service-common/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > ec47909ab3098a890019bc19179786a2c5d7d87c > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java > c6d4d02fd77f4f9a31ea802c497fa23281bf7a75 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > ff06582708ac73d969e1bbdfcec7b672bc9c65c5 > > Diff: https://reviews.apache.org/r/53921/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
