> On Dec. 1, 2016, 12:28 a.m., Hao Hao wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java,
> > line 253
> > <https://reviews.apache.org/r/53520/diff/1/?file=1555269#file1555269line253>
> >
> > Why do we need this?
We have unchecked casts in the code which generates warnings in IntelliJ.
@SuppressWarnings("unchecked") disables these warnings so that we can get
meaningful warnings.
> On Dec. 1, 2016, 12:28 a.m., Hao Hao wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java,
> > line 834
> > <https://reviews.apache.org/r/53520/diff/1/?file=1555269#file1555269line834>
> >
> > Use getGroup?
Here the single query is reused to get multiple groups, so we can't just use
getGroup().
> On Dec. 1, 2016, 12:28 a.m., Hao Hao wrote:
> > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java,
> > line 123
> > <https://reviews.apache.org/r/53520/diff/1/?file=1555271#file1555271line123>
> >
> > Remove throws Exception?
getMSentryRoleByName throws exception, we catch SentryNoSuchObjectException, so
the test can still throw other exceptions.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53520/#review157507
-----------------------------------------------------------
On Nov. 15, 2016, 1:15 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53520/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2016, 1:15 a.m.)
>
>
> Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, Li Li,
> Sravya Tirukkovalur, and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1517: SentryStore shoud actually use function getMSentryRole to get
> roles
>
>
> Diffs
> -----
>
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
> 12245ec6d1b28863e4c1fd7b265e60204732f0e6
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java
> 0484eaade5853d13bc6671c6e0648c14f76116c0
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
> 742798dca6b3ad8c9b9eee1eea5380001d1d0cd9
>
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestDelegateSentryStore.java
> ef32ad40783b3c23c262f73cfa449f2e15368852
>
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
> 66f05841b7fb009278c50d3e6c90e79063623c65
>
> Diff: https://reviews.apache.org/r/53520/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
