----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54445/#review158238 -----------------------------------------------------------
sentry-service/sentry-service-common/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java (line 1031) <https://reviews.apache.org/r/54445/#comment229031> 1. What if it's an empty string (i.e. combination of any space characterds)? Should probably be treated as missing value? 2. Should we strip leading and trailing spaces if any? - Vadim Spector On Dec. 6, 2016, 10:32 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54445/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2016, 10:32 p.m.) > > > Review request for sentry, Alexander Kolbasov, Colin Ma, Hao Hao, Vamsee > Yarlagadda, and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > Both the server_name and action feilds are mandatory in previlage request. > I have made changes in the TSentryPrivilege object validation logic in sentry > server which is applied as soon as receiving Thrift message from client. > If the validation is failed exception is raised and appropriate error is > message is sent. > > > Diffs > ----- > > > sentry-service/sentry-service-common/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java > 15b339f > > Diff: https://reviews.apache.org/r/54445/diff/ > > > Testing > ------- > > I have done unit tests using sentry cli thrift client. > > > Thanks, > > kalyan kumar kalvagadda > >
