----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54464/#review158405 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1258) <https://reviews.apache.org/r/54464/#comment229171> It is neat, but does it actually work? - Alexander Kolbasov On Dec. 7, 2016, 2:39 a.m., Vamsee Yarlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54464/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2016, 2:39 a.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, and kalyan kumar > kalvagadda. > > > Repository: sentry > > > Description > ------- > > This change will ensure that multiple calls to the DB are replaced with a > single call that looks for multiple matching values. > > More reference: > Checkout "Collections" section under > http://etutorials.org/Programming/Java+data+objects/Chapter+9.+The+JDO+Query+Language/9.6+The+Query+Filter/ > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > f773a4443e81c5cde3aca0056a2e33d528bf4ec9 > > Diff: https://reviews.apache.org/r/54464/diff/ > > > Testing > ------- > > Verified the changes by running the unit tests of TestSentryStore and all 40 > tests passed. > > ```bash > vamsee-MBP:sentry-service-server vamsee$ mvn clean test -Dtest=TestSentryStore > ... > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.sentry.provider.db.service.persistent.TestSentryStore > 2016-12-06 18:30:07.974 java[5930:877254] Unable to load realm info from > SCDynamicStore > Tests run: 40, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 16.984 sec - > in org.apache.sentry.provider.db.service.persistent.TestSentryStore > > Results : > > Tests run: 40, Failures: 0, Errors: 0, Skipped: 2 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 38.016s > [INFO] Finished at: Tue Dec 06 18:30:24 PST 2016 > [INFO] Final Memory: 59M/660M > [INFO] > ------------------------------------------------------------------------ > ``` > > > Thanks, > > Vamsee Yarlagadda > >
