> On Dec. 5, 2016, 9:25 p.m., Vadim Spector wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarder.java, > > line 79 > > <https://reviews.apache.org/r/54338/diff/1/?file=1575128#file1575128line79> > > > > do we still need ctors to be public, if we have public static create()?
It is used by UpdateForwarderWithHA, so it can't be private, but it can be package-private. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/#review158055 ----------------------------------------------------------- On Dec. 3, 2016, 6:52 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54338/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2016, 6:52 a.m.) > > > Review request for sentry, Colin Ma, Hao Hao, kalyan kumar kalvagadda, Vamsee > Yarlagadda, and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > SENTRY-1515: Cleanup exception handling in SentryStore > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/Updateable.java > 4dc3a0cebdff89ee2f9070e4d822a28dbd164c08 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java > 3695709e03e683afe6196def53883e37e4910a1c > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateForwarder.java > 73872813fb37428529f674fef924f5a05d23c2f6 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/UpdateablePermissions.java > 3d756c914a1d79db15ab66eaa657c96d70e0dd1c > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > 2ee06f9f236694f87beb9466285bb6363a0007de > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java > f717f38cb14ea7594f87ec6c6bf30b78241dfed6 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > f773a4443e81c5cde3aca0056a2e33d528bf4ec9 > > Diff: https://reviews.apache.org/r/54338/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
