----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review159494 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 281) <https://reviews.apache.org/r/54454/#comment230503> I'm working on SENTRY-1547 and SENTRY-1548. Fixes for both of them are in place. I had to manually split them to create seperate diff files. I messed it. One of them would be request.getPrivileges(). I will probably publish complete diff and appropriately docuement just for review. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 282) <https://reviews.apache.org/r/54454/#comment230504> Agree. I will change it sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 283) <https://reviews.apache.org/r/54454/#comment230505> Will change the description. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 286) <https://reviews.apache.org/r/54454/#comment230506> I'm working on SENTRY-1547 and SENTRY-1548. Fixes for both of them are in place. I will probably publish complete diff and appropriately docuement just for review. - kalyan kumar kalvagadda On Dec. 14, 2016, 10:38 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54454/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2016, 10:38 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, > and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > SENTRY-1548 Setting GrantOption to UNSET upsets Sentry > > I have made changes assuming that grant option is either true/false removing > unset. > Also, added code so that sentry server could validate the TSentryPrivilege > object constructed from the Thrift message received client. If the validation > is failed exception is raised and appropriate error is message is sent. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 898632d > > Diff: https://reviews.apache.org/r/54454/diff/ > > > Testing > ------- > > Verfied the changes using sentry thrift client. > > > Thanks, > > kalyan kumar kalvagadda > >
