----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52795/#review160773 -----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java (lines 121 - 128) <https://reviews.apache.org/r/52795/#comment231988> Why do we have to drop a sentry table privilege during create table? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java (lines 179 - 185) <https://reviews.apache.org/r/52795/#comment231989> Same question as above? Why does create commands involve in drop privileges? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java (line 417) <https://reviews.apache.org/r/52795/#comment231991> nit. How about Boolean.parseBoolean ? https://docs.oracle.com/javase/7/docs/api/java/lang/Boolean.html#parseBoolean(java.lang.String) sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListenerNotificationLog.java (line 109) <https://reviews.apache.org/r/52795/#comment231992> nit. Strings.isNullOrEmpty()? https://google.github.io/guava/releases/snapshot/api/docs/com/google/common/base/Strings.html#isNullOrEmpty-java.lang.String- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java (line 163) <https://reviews.apache.org/r/52795/#comment231993> If notificationLogEnabled is set to false, then in the new logic we simply skip setting up the hmsFollowerExecutor which is not the case in the original code. I thought we should simply fall back to the original metastore listener than the notification log listener. - Vamsee Yarlagadda On Dec. 20, 2016, 12:21 a.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52795/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2016, 12:21 a.m.) > > > Review request for sentry, Alexander Kolbasov, Anne Yu, kalyan kumar > kalvagadda, Li Li, and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > SENTRY-1499: Add feature flag for using NotificationLog > > 1. Keep two SentryMetastorePostEventListeners. One for using notificationlog, > another for not(Used the original SentryMetastorePostEventListeners from > master > https://github.com/apache/sentry/blob/master/sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java). > 2. Add feature flag for using HMSFollower and > SentryMetastorePostEventListeners with notification log. > > Change-Id: I46a11d27ae0159a735b6049e9b7c78216d0e5346 > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java > 75190c1805162e11baf7c4553668693e4e6bb3c4 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListenerNotificationLog.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > a9d49f86961f1ced1af40afcfe6172f884a23d44 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > d80fa1e71c165b7f1faf1c50c451e049d76b770b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 61b24fa0e9f221b75ae343fc534b4d82fbce272a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerInBuiltDeserializer.java > c4be62db71e67099f22f3ba8991e03a32fb0f28a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java > 6f1886f942ca80ab4c356b81777d3ac336017292 > > Diff: https://reviews.apache.org/r/52795/diff/ > > > Testing > ------- > > > Thanks, > > Hao Hao > >
